Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: jakarta-commons-codec https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225922 ------- Additional Comments From pcheung@xxxxxxxxxx 2007-04-16 10:08 EST ------- (In reply to comment #3) > (In reply to comment #2) > >... > > X verify source and patches (md5sum matches upstream, know what the patches do) > > - md5sum do not match with upstream tar ball > OK, this should be fixed now With the svn export, the source from the svn checkout and the tar ball is different: Only in ../CODEC_1_3/: build.properties.sample Only in ../CODEC_1_3/: build.xml Only in ../CODEC_1_3/: checkstyle.xml Only in src/: conf Only in ../CODEC_1_3/: .cvsignore Only in ../CODEC_1_3/: default.properties Only in src/: java Only in ../CODEC_1_3/: LICENSE-header.txt Only in ../CODEC_1_3/: LICENSE.txt Only in ../CODEC_1_3/: maven.xml Only in src/: media Only in ../CODEC_1_3/: NOTICE.txt Only in ../CODEC_1_3/: project.properties Only in ../CODEC_1_3/: project.xml Only in ../CODEC_1_3/: PROPOSAL.html Only in ../CODEC_1_3/: RELEASE-NOTES-1.0-dev.txt Only in ../CODEC_1_3/: RELEASE-NOTES-1.1.txt Only in ../CODEC_1_3/: RELEASE-NOTES-1.2.txt Only in ../CODEC_1_3/: RELEASE-NOTES.txt Only in ../CODEC_1_3/: RELEASE-PLAN Only in ../CODEC_1_3/: src Only in src/: test Only in ../CODEC_1_3/: TODO Only in ../CODEC_1_3/: xdocs Do you need a tag when doing the svn export? (seems like it's currently checking out from the head?) > > > ... > > * if possible, replace PreReq with Requires(pre) and/or Requires(post) > > X specfile is legible > > - Are these still needed: Requires(post): /bin/rm /bin/ln, Requires(postun): > > /bin/rm? > Removed > Great! > >... > > X summary should be a short and concise description of the package > > Summary is just the name of the package > Fixed Thanks. > > New srpm here: > https://mwringe.108.redhat.com/files/documents/175/337/jakarta-commons-codec-1.3-8jpp.1.src.rpm > -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review