[Bug 1108395] Review Request: netgen-mesher - Automatic mesh generation tool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1108395



--- Comment #5 from Sandro Mani <manisandro@xxxxxxxxx> ---

> ---> About this - Is there a specific reason why .desktop and icons are in -common instead of the base package?

Yes, you should theoretically be able to install just netgen-mesher-openmpi or
netgen-mesher-mpich and then, when loading the respective MPI environment, i.e.
/usr/lib64/openmpi/bin will be added to the PATH, and the desktop file should
*theoretically* launch that executable. So putting the desktop file in common
makes is valid for all variants of the netgen-mesher executable. Probably
somewhat of an overkill, but yeah :)

> ---> Could this (and few more shared-libs-calls-exit) be fixed or brought to attention of the upstream folks?

Yes, could also try to get some of the patches upstreamed

> ---> From the build log and buildroot, the patches are applied during build. 

%autosetup does this


Spec URL: http://smani.fedorapeople.org/review/netgen-mesher.spec
SRPM URL: http://smani.fedorapeople.org/review/netgen-mesher-5.1-5.fc21.src.rpm

%changelog
* Sat Jun 14 2014 Sandro Mani <manisandro@xxxxxxxxx> - 5.1-5
- Add subpackage for private headers
- Add patches from salome
- Make common package noarch
- Add missing %%{?_isa}

Remarks about private headers and salome patch:
- Private headers are needed to compile the salome-smesh netgen plugin (which
is in turn required for salome-meca -> code aster). Instead of going the way of
a bundling exception and what not, I guess this is the simplest approach.
- Salome patches: reviewing the patch, they just fixed various issues with the
code, not otherwise changing the behaviour of the code. So again, just patching
the sources directly is easier than bundling a separate netgen in salome.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]