https://bugzilla.redhat.com/show_bug.cgi?id=1098778 Petr Šabata <psabata@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Petr Šabata <psabata@xxxxxxxxxx> --- It looks pretty good, however! I don't see `utf8' used anywhere but in the POD of your patch. I'd say you can drop that BR entirely. Also, I think Time::HiRes is pulled in by the documentation (which shouldn't be happening and may change in the near future) rather than the actual code. I think it'd be safer if you required it explicitly. Consider doing those changes before pushing. I'm approving the package now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review