https://bugzilla.redhat.com/show_bug.cgi?id=1101235 --- Comment #3 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- naming: ok I question the value of a -helpers subpkg, only value is saving ~100k in the multilib case (e.g. avoids an extra 100k of i686 binary on x86_64 systems, but they payload doesn't land on disk due to arch coloring anyway) As mentioned in comment #2 1. subpkgs MUST Requires: %{name}%{?_isa} = %{version}-%{release} 2. %{_libdir}/libqauth.so MUST be owned by -devel subpkg, I'd suggest (main) %{_libdir}/libqauth.so.0* and -devel %{_libdir}/libqauth.so 3. -devel subpkg MUST own %{_includedir}/QAuth , I'd suggest switching %{_includedir}/QAuth/* to %{_includedir}/QAuth/ 4. %%description currently mentions Qt5, but no qt5 support is currently included. I'd suggest leaving versions out, use something like %description QAuth is a Qt user authentication library... instead (to be version agnostic). 5. licensing mostly ok, but SHOULD make it clearer if possible. Afaict, the library itself is LGPLv2+, and the helper portion is GPLv2+, is that correct? If so, please clarify that in a .spec comment near the License: tag 6. SHOULD document need for Requires: xorg-x11-xinit -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review