https://bugzilla.redhat.com/show_bug.cgi?id=1107600 Kalev Lember <kalevlember@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |kalevlember@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |kalevlember@xxxxxxxxx Flags| |fedora-review+ --- Comment #1 from Kalev Lember <kalevlember@xxxxxxxxx> --- Fedora review libhif-0.1.0-1.fc20.src.rpm 2014-06-10 + OK ! needs attention + rpmlint warnings are harmless and can be ignored + The package is named according to Fedora packaging guidelines + The spec file name matches the base package name. + The package meets the Packaging Guidelines + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The license field in the spec file matches the actual license + The package contains the license file (COPYING) + Spec file is written in American English + Spec file is legible + Upstream sources match the sources in the srpm 50d2fcc5cd61d93af70168a4a4ea1e1b libhif-0.1.0.tar.xz 50d2fcc5cd61d93af70168a4a4ea1e1b Download/libhif-0.1.0.tar.xz + The package builds in koji n/a ExcludeArch bugs filed + BuildRequires look sane n/a locale handling + ldconfig in %post and %postun + Package does not bundle copies of system libraries n/a Package isn't relocatable + Package owns all the directories it creates + No duplicate files in %files + Permissions are properly set + Consistent use of macros + The package must contain code or permissible content n/a Large documentation files should go in -doc subpackage + Files marked %doc should not affect package + Header files should be in -devel n/a Static libraries should be in -static + Library files that end in .so must go in a -devel package + -devel must require the fully versioned base + Packages should not contain libtool .la files n/a Proper .desktop file handling + Doesn't own files or directories already owned by other packages + Filenames are valid UTF-8 Looks good to me, just one minor nit: No need use --disable-dependency-tracking in the spec file since the %configure macro already includes this. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review