[Bug 1106324] Review Request: rubygem-minitest4 - Small and fast replacement for ruby's huge and slow test/unit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1106324



--- Comment #4 from Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> ---
Thank you for initial comments!

(In reply to Ken Dreyer from comment #3)
> - This package conflicts with rubygem-minitest-4.7.0-2.fc20, so we should
> add "Conflicts: rubygem-minitest = 4.7.0" to be on the safe side.
> 
> - There is a rpmlint error about useless-provides for rubygem(minitest). Can
> we remove that line? I thought rubygems-devel contained an RPM macro to add
> that particular Provides automatically for %{gem_name}?
> 
> - There is an rpmlint warning about mixed-use-of-spaces-and-tabs "(spaces:
> line 53, tab: line 1)"
> 
> - There is an rpmlint warning about "bogus date in %changelog: Sun Jan 21
> 2012 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxx> - 2.10.1-1" which we might as
> well fix here.
> 

The below should fix these.

http://mtasaka.fedorapeople.org/Review_request/gem-related/rubygem-minitest4-4.7.0-4.fc.src.rpm
http://mtasaka.fedorapeople.org/Review_request/gem-related/rubygem-minitest4.spec

* Mon Jun  9 2014 Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> - 4.7.0-4
- rpmlint fix
- Filter out redundant Provides
- Add Conflicts for older rubygem-minitest

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]