[Bug 1101043] Review Request: ming - A library for generating Macromedia Flash files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1101043



--- Comment #7 from Ralf Corsepius <rc040203@xxxxxxxxxx> ---
(In reply to Dominik 'Rathann' Mierzejewski from comment #4)
> (In reply to Ralf Corsepius from comment #3)
> > The fact you enabled perl mandates (MUSTFIX!) further Perl-related changes
> > to the spec:
> > - BR: perl(Cwd), perl(strict)
> 
> Why? I can't find those anywhere in the guidelines.

We have a rule to specify all perl-modules as BR:, a package directly depends
upon while building:

In this case, it's perl_ext/Makefile.PL
# grep 'use ' perl_ext/Makefile.PL | sort -u
use Cwd qw(abs_path cwd);
use ExtUtils::MakeMaker;
use strict;

> > +Provides: perl-SWF = %{version}.%{release}
> > +Provides: perl-SWF%{_isa} = %{version}.%{release}
> 
> Was the dot (.) here intentional? I'd think it should be a dash (-)
You are right - These should be dashes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]