[Bug 1060924] Review Request: rubygem-unicode - Unicode normalization library for Ruby

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1060924



--- Comment #3 from Dan Callaghan <dcallagh@xxxxxxxxxx> ---
(In reply to Ken Dreyer from comment #1)
> Mind conditionalizing the Requires and Provides to follow the latest Ruby
> Packaging Guidelines? For example:
> 
>   %if 0%{?fc19} || 0%{?fc20} || 0%{?el7}
>   Requires:       ruby
>   Requires:       ruby(rubygems)
>   %endif
> 
>   %if 0%{?fc19} || 0%{?fc20} || 0%{?el7}
>   Provides: rubygem(%{gem_name}) = %{version}
>   %endif

I conditionalized the rubygem Requires/Provides. The requirement on ruby is
still needed though, since this is a C extension so it's only compatible with
MRI.

> Also, I'm getting a build failure on Rawhide:
> http://koji.fedoraproject.org/koji/taskinfo?taskID=6900143
> 
> "mv: cannot stat
> '/builddir/build/BUILDROOT/rubygem-unicode-0.4.4-1.fc21.x86_64/usr/share/
> gems/gems/unicode-0.4.4/lib/unicode': No such file or directory"

Looks like on F21+ rubygems has been made smarter about installing C extensions
to %{_libdir} so I have conditionalized the paths here as well.

I also updated to 0.4.4.1 of the gem, which is just a change to add license
metadata to the gemspec.

http://fedorapeople.org/~dcallagh/rubygem-unicode/rubygem-unicode.spec
http://fedorapeople.org/~dcallagh/rubygem-unicode/rubygem-unicode-0.4.4.1-1.fc21.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]