https://bugzilla.redhat.com/show_bug.cgi?id=1103554 --- Comment #8 from raphgro@xxxxxx <projects.rg@xxxxxxxx> --- (In reply to Ralf Corsepius from comment #4) > This package has lot of issues. I do not want to sound too negative, but I > fear it'll be a long and tiresome process to get this package into Fedora. Well, having to do homework isn't a good point to argue against required bot worth effort. Upstream is not forced to apply each Fedora policy... ;) > 1. Packaging: > Please properly split the package into <main> and *-devel subpackages: > - *.so.* belong into *-devel unless they are dlopened by name. > - man3/ are devel doc and therefore belong into *-devel. > - *.a are not supposed to be shipped in Fedora at all. > - Please be more selective in %files sections. The way you have written them > is very sensitive to accidentially picking up files a package is not > supposed to contain (cf. *devel vs. <main>). I'll clean up the build, so only the important files should be packaged in. Not sure what to do about manpages, I should skip them completely. > 2. Contents: > - Most of the man3/* manpages are junk and are likely to conflict with other > packages. So just ignore and leave them out of the package? > - The *-doc package contains a lot of files which are not supposed to be > shipped. Please tell me the concrete file names. The sense is to ship html documentation cause doxygen produces that, but we could just ship Doxyfile in -devel and let the user decide if it wants to generate by itself. > 3. Bundled libraries: > This package bundles quite a number of sources from other origins (boost, > json2*.js, sha1, etc.). Please modify the package to use external versions > whenever possible. Hmmm. That's Fedora's policy and a good one. Maybe I have to work with upstream to fix that. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review