Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: marble - A KDE Desktop Globe https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233754 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-04-15 12:54 EST ------- Well, for 0.3.1-1: * BuildRequires - At least, cmake, desktop-file-utils are missing. * cmake log verboseness - And when I try local rpmbuild, the build log leaves only unuseful messages like: --------------------------------------------------- [ 1%] Generating ui_placemarkinfodialog.h [ 3%] Generating katlastoolbox.moc [ 4%] Generating katlascontrol.moc [ 6%] Generating katlasview.moc [ 7%] Generating katlasviewinputhandler.moc [ 9%] Generating searchlistview.moc --------------------------------------------------- We cannot judge from this log whether compilation is done properly (and actually in this case it was wrong because the log says as folloing). --------------------------------------------------- + /usr/lib/rpm/find-debuginfo.sh /home/tasaka1/rpmbuild/BUILD/marble extracting debug info from /home/tasaka1/rpmbuild/INSTROOT/marble-0.3.1-1.fc6_LC-root-tasaka1/usr/bin/marble 0 blocks --------------------------------------------------- Usually the verbose log can be gained by using "make VERBOSE=1" for cmake. Please check: http://fedoraproject.org/wiki/PackagingDrafts/cmake * Fedora specific compilation flags - As said above, fedora specific compilation flags are not passed. When I use "make VERBOSE=1", the log says: --------------------------------------------------- /usr/bin/cmake -E cmake_progress_report /home/tasaka1/rpmbuild/BUILD/marble/CMakeFiles 2 [ 39%] [ 41%] Building CXX object src/CMakeFiles/marble.dir/katlascontrol.o /usr/bin/c++ -I/home/tasaka1/rpmbuild/BUILD/marble/src -DQT_SHARED -O2 -msse -o src/CMakeFiles/marble.dir/katlascontrol.o -c /home/tasaka1/rpmbuild/BUILD/marble/src/katlascontrol.cpp --------------------------------------------------- Using CXXFLAGS seems good * macros - Please use macros when possible. /usr/bin/qmake-qt4 should be %{_bindir}/qmake-qt4 ? -msse - As the above log says, -msse seems to be used anyway. ? Home page - Wiki ( http://en.wikipedia.org/wiki/Marble_(KDE) ) refers to http://edu.kde.org/marble/ for the home page. ? Timestamps - Well, there are many files which are installed from tarball without any modification (many png, svg, PNT files), so keeping timestamps on these files is _strongly_ recommended. However, cmake uses its original installation mechanism and I don't know how I can make cmake keep timestamps... -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review