https://bugzilla.redhat.com/show_bug.cgi?id=1101043 Ralf Corsepius <rc040203@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Ralf Corsepius <rc040203@xxxxxxxxxx> --- The fact you enabled perl mandates (MUSTFIX!) further Perl-related changes to the spec: - BR: perl(Cwd), perl(strict) - Add R: perl(:MODULE_COMPAT_%...) to *-perl I'd propose the following change to your spec: # diff -u ming.spec.orig ming.spec --- ming.spec.orig 2014-06-03 07:53:23.180652587 +0200 +++ ming.spec 2014-06-03 13:46:11.970988831 +0200 @@ -43,7 +43,13 @@ %package perl Summary: A Perl module for generating Macromedia Flash files using the Ming library +Provides: perl-SWF = %{version}.%{release} +Provides: perl-SWF%{_isa} = %{version}.%{release} BuildRequires: perl(ExtUtils::MakeMaker) +BuildRequires: perl(Cwd) +BuildRequires: perl(strict) + +Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) %description perl A perl module for generating Macromedia Flash files using the Ming library. @@ -111,10 +117,8 @@ install -d %{buildroot}%{tcl_sitearch}/ming mv %{buildroot}%{_libdir}/ming/tcl/mingc.so %{buildroot}%{tcl_sitearch}/ming/ -%if 1 %check -LD_LIBRARY_PATH=$(pwd)/src/.libs make check -%endif +LD_LIBRARY_PATH=${RPM_BUILD_ROOT}%{_libdir} make check %post -p /sbin/ldconfig The P: perl-SWF... are optional and just "convenience" to perl-users. The LD_LIBRARY_PATH change would pickup shared libraries from RPM_BUILD_ROOT instead of the build-tree. It's an option I consider to be superior. (Sorry for having missed this possiblity in my previous comment). As I am sure you can handle these issues after git-import: APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review