https://bugzilla.redhat.com/show_bug.cgi?id=1079640 Vít Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vondruch@xxxxxxxxxx --- Comment #2 from Vít Ondruch <vondruch@xxxxxxxxxx> --- Just a few notes from me: * Don't use Rake to execute test suite - We typically don't use Rake to execute test suite, since it almost always needs some additional unnecessary dependencies. * Execute the test suite in .%{gem_instdir} - Although there is more places where the test suite can be executed, execution of the test suite in '.' directory is the worst option, since it is the content of gem before repackaging. The best place IMO is the .%{gem_instdir} * Don't use Bundler - Similarly to Rake, we trying to avoid Bundler. It typically downloads some external dependencies or doing another stuff which is more or less against what we are trying to achieve, i.e. using system dependencies. * -doc sub package should not R: ruby(rubygems) - It always depends on the main package, so there is no need for any other dependencies. * Keep the documentation in %{gem_instdir} - We typically keep the README as well as the LICENSE files on their original places. However we might disagree on this. * Is the patching of .gitignore needed? - Not sure about this stuff. Why are you doing so? Why not %exclude it as you are doing with other files? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review