https://bugzilla.redhat.com/show_bug.cgi?id=1102858 --- Comment #2 from Jerry James <loganjerry@xxxxxxxxx> --- Thank you very much for the review, Björn. (In reply to Björn "besser82" Esser from comment #1) > ---> It might be nice to ask upstream for adding copyright / license > headers atop the source-files I will make the attempt. > ===== Additional Information ===== > > * Please conditionalize the build of the py3-pkg, so this can be easily > ported to other releases (EPEL7), which don't offer support for py3, yet. Done. > * The %%clean-section is unneccessary and will override the default %%clean > in rpm-macros. Please drop it. This is not true. With the %clean section as is, rpmbuild --clean removes both repoze.sphinx.autointerface-0.7.1 and python3-python-repoze-sphinx-autointerface-0.7.1-1.fc21 from BUILD. If I remove the %clean section, then rpmbuild --clean removes the former but leaves the latter behind. > * For a quick fix-up, I attached you a patch. Thank you, I appreciate the patch. I have modified your suggested patch a little due to differences in taste. New URLs: Spec URL: http://jjames.fedorapeople.org/python-repoze-sphinx-autointerface/python-repoze-sphinx-autointerface.spec SRPM URL: http://jjames.fedorapeople.org/python-repoze-sphinx-autointerface/python-repoze-sphinx-autointerface-0.7.1-2.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review