[Bug 1103034] Review Request: python-django-stopforumspam - Django middleware for blocking IPs listed in stopforumspam.com

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1103034

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx
            Summary|Review Request:             |Review Request:
                   |python-django-stopforumspam |python-django-stopforumspam
                   |                            |- Django middleware for
                   |                            |blocking IPs listed in
                   |                            |stopforumspam.com
              Flags|                            |fedora-review+



--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ Package builds successful in mock f21

+ rpmlint on generated rpms gave
python-django-stopforumspam.noarch: W: spelling-error Summary(en_US) middleware
-> middle ware, middle-ware, middleweight
python-django-stopforumspam.noarch: W: spelling-error %description -l en_US
middleware -> middle ware, middle-ware, middleweight
python-django-stopforumspam.noarch: W: spelling-error %description -l en_US
com's -> con's, om's, come's
python-django-stopforumspam.noarch: W: spelling-error %description -l en_US py
-> pt, p, y
python-django-stopforumspam.noarch: W: spelling-error %description -l en_US
sfsupdate -> update
python-django-stopforumspam.src: W: spelling-error Summary(en_US) middleware ->
middle ware, middle-ware, middleweight
python-django-stopforumspam.src: W: spelling-error %description -l en_US
middleware -> middle ware, middle-ware, middleweight
python-django-stopforumspam.src: W: spelling-error %description -l en_US com's
-> con's, om's, come's
python-django-stopforumspam.src: W: spelling-error %description -l en_US py ->
pt, p, y
python-django-stopforumspam.src: W: spelling-error %description -l en_US
sfsupdate -> update
2 packages and 0 specfiles checked; 0 errors, 10 warnings.
==> no issues here

+ Source verified with usptream tarball as (sha256sum)
srpm tarball: 8b329b80d30cd83b97a6e8049fb0f51206215d5ca5255ff3ebe4bd2174717813
upstream tarball :
8b329b80d30cd83b97a6e8049fb0f51206215d5ca5255ff3ebe4bd2174717813

+ License is BSD as per given on upstream URL 

Suggestions:
1) Decide if you need this package in EPEL or not otherwise all the cleanup
guidelines should be followed like
   a) no need of removal of buildroot in %install
   b) python2_site* macros at top of spec file are not needed

2) Use http://fedoraproject.org/wiki/Packaging:Python#Macros in %files
change %{python_sitelib} to %{python2_sitelib}

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]