[Bug 1086231] Review Request: nodejs-jsonparse - Pure-js JSON streaming parser for node.js

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1086231



--- Comment #6 from Tom Hughes <tom@xxxxxxxxxx> ---
Looks pretty good now. Just a couple of minor points:

* It's better to do the "%nodejs_symlink_deps --check" at the top of %check

* I don't think the samplejson directory needs to be installed - it's just
sample data for the benchmark script by the looks of it

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]