https://bugzilla.redhat.com/show_bug.cgi?id=1101521 Lubomir Rintel <lkundrak@xxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #10 from Lubomir Rintel <lkundrak@xxxxx> --- Seems reasonably good to me now. I see that you've added the format-security patch; which is great. I'm a bit concerned about amount of stuff done in %prep. I understand it's not very easy to get rid of those, but you still might want to open a ticket upstream (to fix their encodings & FSF address, etc.). (By the way, your server seems to have SSL misconfigured: $ curl https://didier.dnsdynamic.net/repository/fc20/geomorph/geomorph.spec curl: (60) The certificate was signed using a signature algorithm that is disabled because it is not secure. More details here: http://curl.haxx.se/docs/sslcerts.html) Also, there's two tiny issues that you should address before importing the package: 1.) Adding --prefix to %configure is redundant; see 'rpm --eval %configure' 2.) You should take care not to modify timestamps of shared files when converting their encodings: 'mv -f $file.utf8 $file' should be preceded by by 'touch -r $file $file.utf8' I can't see that blocking the review though. Please proceed with http://fedoraproject.org/wiki/Package_SCM_admin_requests APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review