[Bug 908088] Review Request: ascend - ASCEND modelling environment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=908088



--- Comment #12 from Rex Dieter <rdieter@xxxxxxxxxxxx> ---
License: OK

Item 3 above not completely fixed, there's still one reference to 
%{python_sitearch}

8.  -libs subpkg MUST include ldconfig scriptlets (and now main pkg no longer
needs them)

9.  nothing depends on new -libs subpkg.  You probably want to add a dependency
to at least the main and -devel subpkgs:
Requires: %{name}-libs%{?_isa} = %{version}-%{release}

(and have -devel drop dep on main pkg).

While we're at it, make -libs, -data dep on main pkg *not* use %_isa (else you
lose the whole point of making a -libs subpkg to be multilib -friendly)

10.  nothing depends on -data subpkg, should main pkg depend on it?  Or is it
optional addon?

11. While on the topic of -libs, I'd recommend it *only* include the shared
library here, plus any essential resources the library may require.  Is there a
reason you added all that other stuff too?

12.  MUST omit extraneous python dep
Requires: python >= 2.4
https://fedoraproject.org/wiki/Packaging:Python#Multiple_Python_Runtimes
(it'll get an automatic dependency on python(abi) instead)

13. MUST omit gcc-c++ dependency,
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Exceptions_2

14. URL: http://ascend.cheme.cmu.edu/
seems inaccessible (at the moment?).  Googling found me http://ascend4.org/
too, but it's not working either.  Please verify which URL is correct.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]