https://bugzilla.redhat.com/show_bug.cgi?id=1100899 --- Comment #6 from Björn "besser82" Esser <bjoern.esser@xxxxxxxxx> --- Created attachment 899924 --> https://bugzilla.redhat.com/attachment.cgi?id=899924&action=edit fix Makefile for parallelized make-jobs Package looks almost fine now. =) Just a few little things: * Please update to new upstream version 0.5.1 (as tagged in git) and drop current `Patch0`, as this is fixed in the new release. * Have a look a my attached patch and apply it to the sources. This will fix parallelized make-jobs, so you can append `%{?_smp_mflags}` again to the invocation of `make`. The patch has already been upstreamed by me as you can see in my pull-request [1]. * You will need to add a blackslash '\' to the line which sets {C,LD}FLAGS, like: `CFLAGS="%{?optflags}" LDFLAGS="%{?__global_ldflags}" \` In other cases the flags are not properly injected into make's default $ENV. * Setting `%config(noreplace)` for the bash-completion is a bad idea, since this file is NOT config as meant to be customized by the user. On newer versions of ratools there might be changes in CLI and the bash-completion WILL change. The `noreplace` is meant for cases when you ship some default config to be customized by the user with the package, so the customized config will NOT be overwritten on pkg-updates. In this case this config must be replaced on updates for said reasons. So please drop the `noreplace` and just use `%config` for this file. Before I'm going to sponsor you into the package-group, I want to see some *INFORMAL* package-reviews made by you. You can find packages, which need a review, over here [2]. Just pick 3 or 4 from that list and try to do a fully-featured review, but without assigning the bug to you or raising the fedora-review-flag in rhbz. [1] https://github.com/danrl/ratools/pull/2 [2] http://fedoraproject.org/PackageReviewStatus/NEW.html -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review