[Bug 1064352] Review Request: rubygem-deep_merge - Merges deep hashes in ruby.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1064352

Ken Dreyer <ktdreyer@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |ktdreyer@xxxxxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |ktdreyer@xxxxxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #2 from Ken Dreyer <ktdreyer@xxxxxxxxxxxx> ---
Hi Steve, I can take this one. Mind conditionalizing the Requires and Provides
to follow the latest Ruby Packaging Guidelines? For example:

  %if 0%{?el6}
  Requires:      ruby(abi) = 1.8
  %endif
  %if 0%{?fc19} || 0%{?fc20} || 0%{?el7}
  Requires:      ruby(release)
  %endif

  %if 0%{?fc19} || 0%{?fc20} || 0%{?el6} || 0%{?el7}
  Provides: rubygem(%{gem_name}) = %{version}
  %endif

It also looks like upstream's test suite is not compatible with Minitest 5, so
Rawhide builds fail. You can use the patch from
https://github.com/danielsdeleo/deep_merge/pull/13

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]