https://bugzilla.redhat.com/show_bug.cgi?id=1101521 --- Comment #1 from Lubomir Rintel <lkundrak@xxxxx> --- 1.) %define major_ver 0.60 You want to use %global here instead. (See http://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define) 2.) You can drop old RPM artifacts These are not necessary anymore: BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) (on top of %install:) %{__rm} -rf %{buildroot} (whole %clean scriptlet) %clean rm -rf $RPM_BUILD_ROOT %defattr(-,root,root,-) 3.) Extra dependencies [lkundrak@odvarok SPECS]$ rpm -qp --requires /home/lkundrak/rpmbuild/RPMS/x86_64/geomorph-0.60.1-1.fc20.x86_64.rpm |grep gtkglext gtkglext-libs libgtkglext-x11-1.0.so.0()(64bit) AutoReq generator creats proper library dependence, you should not require gtkglext-libs explicitely. The same applies to mesa-libGLU. 4.) Consistent use of macros: Use either $RPM_BUILD_ROOT or %{buildroot}. Not both. Also, you're using both "make" and "%{__make}". The double underscore denotes that it's an internal rpm macro -- I suggest you don't needlessly use it. 5.) Locale files dragged in manually: %{_datadir}/locale/*/LC_MESSAGES/geomorph.mo You should use %find_lang instead: http://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files 6.) Please use desktop-file-install to copy the .desktop file It will validate it's correct: http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage 7.) RPMLint unhappy. Here's (apart from the things already mentioned above) what needs addressing: geomorph.x86_64: E: arch-dependent-file-in-usr-share /usr/share/geomorph/0.60.1/scenes/colmap This package installs an ELF binary in the /usr/share hierarchy, which is reserved for architecture-independent files. It should go to %_bindir or be %excluded. geomorph.x86_64: W: devel-file-in-non-devel-package /usr/share/geomorph/0.60.1/scenes/colmap.c A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. Just drop this. You may want to address the other warnings too. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review