https://bugzilla.redhat.com/show_bug.cgi?id=1079745 Ralf Corsepius <rc040203@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #9 from Ralf Corsepius <rc040203@xxxxxxxxxx> --- (In reply to Sven Nierlein from comment #8) > Ok, now i understand. I've corrected this. Updated src.rpm, please. > There is one "Requires: perl(Test::More)" left which i am unsure about. You need to distinguish run-time requirements (Requires:) from build-time requirements. In almost all cases, Test::More is a build-time-only requirement, which is required to exercise a perl module's tests (commonly found under t/ in a source-tree), but is not required at run-time (commonly found under lib/ in a source-tree). FYI: Unlike other reviewers I do not provide you with spec-patches for didactical reasons, because I want you to understand what you are doing and do not want you "blindly copy and paste" others' works. Sorry, if this feels inconvenient to you. I am doing so for your own sake. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review