https://bugzilla.redhat.com/show_bug.cgi?id=1100961 --- Comment #6 from Jeff Backus <jeff.backus@xxxxxxxxx> --- (In reply to Kalev Lember from comment #4) Hi Kalev, > I have a few drive-by comments: > > > %setup -q -n %{name}-%{version} > > Could just say '%setup -q' because %{name}-%{version} is the default for -n. > > > %cmake CMakeLists.txt > > It should be '%cmake .' -- the convention is to pass the directory name to > cmake instead of the CMakeLists.txt file. > > > # Update icon cache > > /usr/bin/gtk-update-icon-cache %{_datadir}/pixmaps &>/dev/null || : > > Please drop the icon cache scriptlets. These aren't meant for the pixbuf > directory but only for the themable directories (e.g. > /usr/share/icons/hicolor). Thanks for the comments. Not sure how much wiggle room there is in changing a spec post approval, but as these changes do not appear to affect the resulting RPMS beyond the icon cache scriplets I have gone ahead and made the changes. I have updated the spec and SRPM files listed above if anyone wants to look at them. I also reran the Koji and fedora-review just in case. Koji Builds: F19: http://koji.fedoraproject.org/koji/taskinfo?taskID=6892592 F20: http://koji.fedoraproject.org/koji/taskinfo?taskID=6892596 F21: http://koji.fedoraproject.org/koji/taskinfo?taskID=6892604 Thanks again! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review