https://bugzilla.redhat.com/show_bug.cgi?id=1101043 Ralf Corsepius <rc040203@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rc040203@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |rc040203@xxxxxxxxxx Flags| |fedora-review? --- Comment #1 from Ralf Corsepius <rc040203@xxxxxxxxxx> --- Taking. Several minor issues: - Package contains a testsuite, but the spec doesn't excercise it. Feel strongly encouraged to add a %check section: %check LD_LIBRARY_PATH=$(pwd)/src/.libs make check - %defattr(-,root,root,-) is only needed to support ancient RHELs. Please remove these, unless you plan to support them. - I recommend to append --disable-silent-rules to %configure instead of using make V=1. This moves "switching on verbosity" from build-time to configure-time (It hard-codes verbosity into Makefiles). - src/ming.h (rsp. src/ming.h.in) contains "dirty code" (Read: a bug) It wraps stdio.h into extern "C" { ... } guards: #ifdef __cplusplus extern "C" { #endif ... #include <stdio.h> ... (#include <stdio.h> should be moved above the 'extern "C"') ATM, this bug seems hidden and harmless, but in general, such misplaced extern "C"s may interfere stdio.h's interaction with C++. Finally, there is a major [MUSTFIX] bug: - The *devel-package isn't multilib-capable, due to hard coded paths in /usr/bin/ming-config. One common approach to work around such issues is to modify such *-config scripts in such a way that they work as wrappers to pkg-config. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review