https://bugzilla.redhat.com/show_bug.cgi?id=1100961 --- Comment #2 from Jeff Backus <jeff.backus@xxxxxxxxx> --- (In reply to Björn "besser82" Esser from comment #1) Hi Björn, Thanks for taking a look at this! > > ===== Issues ===== > > * bad license-tag: > See my explanation below. Good catch! Updated. > > * improper handling of localization-files: > Fedora includes an rpm macro called %find_lang. This macro will locate > all of the locale files that belong to your package (by name), and put > this list in a file. You can then use that file to include all of the > locales. %find_lang should be run in the %install section of your spec > file, after all of the files have been installed into the buildroot. > See > http://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files > Ah! Quite handy. Updated. > * improper handling of desktop-file: > run desktop-file-install *OR* desktop-file-validate > See http://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files > Doh! Fixed. > * to generous glob for manpage (not in guidelines, but good practice): > %{_mandir}/man1/* vs. %{_mandir}/man1/%{name}.1* > Good suggestion. Updated. > > ===== Solution ===== > > NOT approved. Please fix those issues and I'll take another review. I've updated the spec and SRPM at the above locations. Hopefully fixes are satisfactory. Thanks again for the review! Regards, Jeff -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review