https://bugzilla.redhat.com/show_bug.cgi?id=1100901 --- Comment #4 from Colin Walters <walters@xxxxxxxxxx> --- > [!]: All build dependencies are listed in BuildRequires, except for any that > are listed in the exceptions section of Packaging Guidelines. Fixed (I dropped the dependencies). > Note: You are missing buildrequires for rpm-devel and hawkey-devel > [!]: Have a sane version number Fixed, the new version is 2014.11. > [!]: Package consistently uses macros (instead of hard-coded directory > names). > Note: You are using both the %{..}-style macros, and the $...-style > variables ($RPM_BUILD_ROOT in %install for example). > Please use only one of those. Fixed. > [!]: Requires correct, justified where necessary. > Note: Please use package-based requires instead of path-based > requires wherever possible (for ostree, gjs and guestmount for example) Ok...I tend to prefer path-based requires because they allow me to find the binary without having to know the arbitrary package name. For example, /usr/bin/guestmount is contained in "libguestfs-tools-c". > [!]: Upstream URL correct. > Note: Please replace the Source0: with a URL to the sources, for > github sources check: I don't use the github source guidelines because they only work for github. I use this generic tooling to make snapshots of sources that come from GNOME too for example. My tooling around "git archive" is generic to any git repository while still being compatible with RPM versioning requirements. See: https://bugzilla.redhat.com/show_bug.cgi?id=1066176#c5 I explained this a bit more in the comment. > [!]: Final provides and requires are sane (see attachments). > Note: You have an explicit requirement on libguestfs That's expected since the upstream project name is "libguestfs". rpmlint is wrong here. New version here: http://fedorapeople.org/~walters/rpm-ostree-toolbox-2014.11-1.el7.src.rpm http://fedorapeople.org/~walters/rpm-ostree-toolbox.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review