Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: parted https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226230 bugzilla@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium wolfy@xxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO AssignedTo|nobody@xxxxxxxxxxxxxxxxx |wolfy@xxxxxxxxxxxxxxxxxx Flag| |fedora-review?, | |needinfo?(dcantrell@xxxxxxxx | |om) ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2007-04-13 20:58 EST ------- Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)) [!] Rpmlint output: #rpmlint parted-1.8.6-4.src.rpm W: parted no-url-tag rpmlint ~/reports/parted/parted-1.8.6-4.fc7.x86_64.rpm W: parted no-url-tag --> an URL tag should be provided [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must matches the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines. [x] Package is licensed with an open-source compatible license and meet other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type:GPL [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is written in American English. [x] Spec file for the package is legible. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. SHA1SUM : eef9d788f13f4ed461f97051eb0543ffd40830b7 parted-1.8.6.tar.bz2 [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: devel/x86_64 [-] Package is not known to require ExcludeArch, OR: [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Pack aging Guidelines. [!] Duplicate BR: automake (by libtool), libsepol-devel (by libselinux-devel) [x] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package is not relocatable. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [!] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package has a %clean section, which contains rm -rf %{buildroot}. [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [x] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [!] Package requires pkgconfig, if .pc files are present. [x] Development .so files in -devel subpackage, if present. [x] Fully versioned dependency in subpackages, if present. [x] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [-] Package does not own files or directories owned by other packages. === SUGGESTED ITEMS === [x] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on:Devel/x86_64 [x] Package should compile and build into binary rpms on all supported architectures. Tested on:devel/x86_64, devel/i386 [x] Package functions as described. [x] Scriptlets must be sane, if used. [x] The placement of pkgconfig(.pc) files are correct. [x] File based requires are sane. [x] Latest version is packaged. === Issues === 1. Summary ends with dot. As far as I remember (rpmlint does not say anything, and it is latest version) it was preffered to not end sumaries with dot. Not a big deal. 2. parted-devel should require pkconfig. MUSTFIX 3. there is a texinfo file (doc/parted-pt_BR) which might be shipped but is not. 4. %files has a duplicate line: %{_libdir}/libparted-*.so.* is included twice. MUSTFIX -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review