https://bugzilla.redhat.com/show_bug.cgi?id=459125 John Morris <john@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #26 from John Morris <john@xxxxxxxxxxx> --- So those sqlite files contain documentation needed for runtime? I think this is OK because they're not marked %doc: [?]: Package uses nothing in %doc for runtime. However, since they're not %doc, I'd just stick them into the '-data' package and ignore the 'Large documentation must go in a -doc subpackage' problem. I believe the spirit of that rule is if docs aren't needed (by humans), it saves space not to install the -doc subpackage. That doesn't apply here, since the files are needed by runtime. I'm fine with the license file, esp. w/good news about the next release. There are still source files with GPLv2+ headers in them that upstream might need to revise. So, looks great! APPROVED -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review