https://bugzilla.redhat.com/show_bug.cgi?id=1100870 David Dick <ddick@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ddick@xxxxxxxx --- Comment #1 from David Dick <ddick@xxxxxxxx> --- Hi Maryanne, I can't sponsor you, but i can offer you some help. The following patch shows suggested changes to your spec file. Explanations follow; --- perl-Parse-EDID.original 2014-05-24 08:33:55.978581987 +1000 +++ perl-Parse-EDID.spec 2014-05-24 08:48:28.184648360 +1000 @@ -1,15 +1,23 @@ Name: perl-Parse-EDID Version: 1.0.6 -Release: 0%{?dist} +Release: 1%{?dist} Summary: Extended display identification data (EDID) parser License: GPLv3 Group: Development/Libraries URL: http://search.cpan.org/dist/Parse-EDID/ Source0: http://www.cpan.org/authors/id/G/GR/GROUSSE/Parse-EDID-%{version}.tar.gz -BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) BuildArch: noarch +BuildRequires: perl +BuildRequires: perl(base) +BuildRequires: perl(English) +BuildRequires: perl(Exporter) BuildRequires: perl(ExtUtils::MakeMaker) +BuildRequires: perl(strict) +BuildRequires: perl(Test::Kwalitee) BuildRequires: perl(Test::More) >= 0.93 +BuildRequires: perl(Test::Pod) +BuildRequires: perl(Test::Pod::Coverage) +BuildRequires: perl(warnings) Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) %description @@ -34,12 +42,11 @@ make test %files -%defattr(-,root,root,-) -%doc Changes LICENSE META.json README +%doc Changes LICENSE README %{perl_vendorlib}/* %{_mandir}/man3/* %changelog -* Wed May 21 2014 Marianne Lombard <marianne@xxxxxxxxxx> 1.0.6-1 +* Wed May 21 2014 Marianne Lombard <marianne@xxxxxxxxxx> - 1.0.6-1 - Adapting spec to actual guidelines - Specfile autogenerated by cpanspec 1.78. Explanations 1) Release: tags start from 1 2) BuildRoot: is only required for EPEL5 builds. Unless you want to build for EPEL5, you can remove this line 3) BuildRequires: perl - There are a variety of opinions on this BuildRequire, but i haven't seen anyone force it's removal 4) BuildRequires: perl(Test::Kwalitee) - I'm not really sure this is required, as it has no direct effect on the use of this module. I would consider this optional at best. 5) BuildRequires: perl(Test::Pod) and perl(Test::Pod::Coverage) - Once again, a variety of opinions on this one, but i haven't seen anyone force it's removal. The positive effect this has you can be sure that when a "perldoc Parse::EDID" is executed, the user will not see a set of POD errors. 5) BuildRequires: All the other build requires can be found be grepping for 'use ' and 'require ' in the unpacked distribution. Specifying the exact module names helps to protect you if perl packages are split up, both in the CPAN packages, and the default set of packages available in the fedora build environment. 6) defattr(-,root,root,-) is only required for EPEL5 builds. 7) META.json is a file only intended for packaging. It has no use to the end user and may be removed. 8) Changelog just needed an extra dash to comply with rpm guidelines. Running rpmlint on your package will show this error. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review