https://bugzilla.redhat.com/show_bug.cgi?id=459125 --- Comment #21 from John Morris <john@xxxxxxxxxxx> --- This is one giant package, whew. Review follows. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= [?]: Package uses nothing in %doc for runtime. *** These are suspicious: Start_page.html and freecad.{qch,qhc} Start_page.html might be for the initial GUI. freecad.{qch,qhc} are SQLite databases. ------ - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 47902720 bytes in 6 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 47912960 bytes in /usr/share freecad-0.13-5.fc21.i686.rpm:47912960 See: http://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines *** This is the funny '/usr/share/doc/freecad/freecad.qch' file again, 47MB ------ - update-desktop-database is invoked in %post and %postun if package contains desktop file(s) with a MimeType: entry. Note: desktop file(s) with MimeType entry in freecad See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop- database *** (from fedora-review tool) ----- [!]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "*No copyright* GPL (v2 or later) (with incorrect FSF address)", "LGPL (v2.1 or later) (with incorrect FSF address)", "LGPL (v2 or later)", "GPL (v3 or later)", "Unknown or generated", "MIT/X11 (BSD like)", "BSL (v1.0)", "LGPL (v2 or later) (with incorrect FSF address)", "BSD (3 clause)", "ISC", "BSD (2 clause)", "*No copyright* LGPL (v2 or later) (with incorrect FSF address)", "GPL (v2 or later) (with incorrect FSF address)", "LGPL (with incorrect FSF address)", "*No copyright* LGPL (v2 or later)", "LGPL (v2.1 or later)", "*No copyright* LGPL (v2.1 or later)". 261 files have unknown license. Detailed output of licensecheck in /home/jman/tmp/freecad/licensecheck.txt [!]: License file installed when any subpackage combination is installed. [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. *** This is confusing: - Software's 'copying.lib' says LGPLv2+ - Specfile says GPLv3+ (the only GPLv3 according to licensecheck.txt is bison artifacts, which contain exceptions) - Otherwise, the most restrictive licenses found in licensecheck.txt are GPLv2+ files; my guess is the specfile should say GPLv2+. [?]: Package does not include license text files separate from upstream. *** This is a SHOULD item, in case a copy of the GPLv2+ license must added by the package ----- [?]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in freecad- data , freecad-doc *** Have %{name} = %{version}-%{release} but not %{name}%{?_isa} = %{version}-%{release}; is this an issue? ----- [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. *** No justification for any patches except the last; the first two are obviously unbundling patches; how about patches 2 & 3? ----- Rpmlint: freecad.i686: E: invalid-soname /usr/lib/freecad/lib/SketcherGui.so SketcherGui.so freecad.i686: W: undefined-non-weak-symbol /usr/lib/freecad/lib/SketcherGui.so Part::BRepOffsetAPI_MakePipeShellPy::add(_object*) freecad.i686: E: invalid-soname /usr/lib/freecad/lib/Robot.so Robot.so freecad.i686: W: undefined-non-weak-symbol /usr/lib/freecad/lib/Robot.so Part::BRepOffsetAPI_MakePipeShellPy::add(_object*) [...] *** I don't understand these; are they an issue? freecad.i686: E: wrong-script-interpreter /usr/lib/freecad/Mod/PartDesign/Scripts/RadialCopy.py python freecad.i686: E: non-executable-script /usr/lib/freecad/Mod/PartDesign/Scripts/RadialCopy.py 0644L python *** Because of initial '#!' line; should these be dealt with? freecad-data.noarch: W: no-documentation *** Bogus: this pkg is to put large, arch-independent files in a 'noarch' pkg; the docs are in the main package. freecad.src:216: W: macro-in-comment %{buildroot} freecad.src:216: W: macro-in-comment %{_libdir} freecad.src:216: W: macro-in-comment %{name} *** Change % to %%, or just remove? Unresolved items ================ [?]: Package functions as described. *** Reviewer has no rawhide install to test against; pkg deps not yet in stable releases [?]: Package should compile and build into binary rpms on all supported architectures. *** Reviewer hasn't run scratch builds ===== MUST items ===== C/C++: [-]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "*No copyright* GPL (v2 or later) (with incorrect FSF address)", "LGPL (v2.1 or later) (with incorrect FSF address)", "LGPL (v2 or later)", "GPL (v3 or later)", "Unknown or generated", "MIT/X11 (BSD like)", "BSL (v1.0)", "LGPL (v2 or later) (with incorrect FSF address)", "BSD (3 clause)", "ISC", "BSD (2 clause)", "*No copyright* LGPL (v2 or later) (with incorrect FSF address)", "GPL (v2 or later) (with incorrect FSF address)", "LGPL (with incorrect FSF address)", "*No copyright* LGPL (v2 or later)", "LGPL (v2.1 or later)", "*No copyright* LGPL (v2.1 or later)". 261 files have unknown license. Detailed output of licensecheck in /home/jman/tmp/freecad/licensecheck.txt [!]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. Note: Especially check following dirs for bundled code: /home/jman/tmp/freecad/upstream- unpacked/Source0/freecad-0.13.1830/src/Gui/iisTaskPanel/include, /home/jman/tmp/freecad/upstream- unpacked/Source0/freecad-0.13.1830/src/3rdParty [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [?]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in freecad [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [-]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel +++ Python libs are all internal, so python packaging guidelines mostly don't apply ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in freecad- data , freecad-doc [?]: Package functions as described. [x]: Latest version is packaged. [?]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define plugin_regexp /^\\\(libFreeCAD.*%(for i in %{plugins}; do echo -n "\\\|$i\\\|$iGui"; done)\\\)\\\(\\\|Gui\\\)\\.so/d [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 47912960 bytes in /usr/share freecad-0.13-5.fc21.i686.rpm:47912960 See: http://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: freecad-0.13-5.fc21.i686.rpm freecad-data-0.13-5.fc21.noarch.rpm freecad-doc-0.13-5.fc21.noarch.rpm freecad-0.13-5.fc21.src.rpm freecad.i686: E: explicit-lib-dependency python-matplotlib freecad.i686: E: invalid-soname /usr/lib/freecad/lib/SketcherGui.so SketcherGui.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/Robot.so Robot.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/PartGui.so PartGui.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/RobotGui.so RobotGui.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/Complete.so Complete.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/ReverseEngineering.so ReverseEngineering.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/DrawingGui.so DrawingGui.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/Sketcher.so Sketcher.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/WebGui.so WebGui.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/MeshPart.so MeshPart.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/Part.so Part.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/Start.so Start.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/MeshPartGui.so MeshPartGui.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/Points.so Points.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/Drawing.so Drawing.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/libFreeCADApp.so libFreeCADApp.so freecad.i686: W: shared-lib-calls-exit /usr/lib/freecad/lib/libFreeCADApp.so exit@GLIBC_2.0 freecad.i686: E: invalid-soname /usr/lib/freecad/lib/RaytracingGui.so RaytracingGui.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/MeshGui.so MeshGui.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/PointsGui.so PointsGui.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/CompleteGui.so CompleteGui.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/Mesh.so Mesh.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/FreeCADGui.so FreeCADGui.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/Assembly.so Assembly.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/InspectionGui.so InspectionGui.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/FreeCAD.so FreeCAD.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/Raytracing.so Raytracing.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/ImageGui.so ImageGui.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/AssemblyGui.so AssemblyGui.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/libFreeCADGui.so libFreeCADGui.so freecad.i686: W: shared-lib-calls-exit /usr/lib/freecad/lib/libFreeCADGui.so exit@GLIBC_2.0 freecad.i686: E: invalid-soname /usr/lib/freecad/lib/FemGui.so FemGui.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/libFreeCADBase.so libFreeCADBase.so freecad.i686: W: shared-lib-calls-exit /usr/lib/freecad/lib/libFreeCADBase.so exit@GLIBC_2.0 freecad.i686: E: invalid-soname /usr/lib/freecad/lib/QtUnitGui.so QtUnitGui.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/ImportGui.so ImportGui.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/Fem.so Fem.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/ReverseEngineeringGui.so ReverseEngineeringGui.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/Inspection.so Inspection.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/StartGui.so StartGui.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/Image.so Image.so freecad.i686: E: wrong-script-interpreter /usr/lib/freecad/Mod/PartDesign/Scripts/RadialCopy.py python freecad.i686: E: non-executable-script /usr/lib/freecad/Mod/PartDesign/Scripts/RadialCopy.py 0644L python freecad.i686: E: incorrect-fsf-address /usr/lib/freecad/Mod/Draft/draftlibs/dxfColorMap.py freecad.i686: E: wrong-script-interpreter /usr/lib/freecad/Mod/PartDesign/Scripts/Epitrochoid.py python freecad.i686: E: non-executable-script /usr/lib/freecad/Mod/PartDesign/Scripts/Epitrochoid.py 0644L python freecad.i686: E: non-executable-script /usr/lib/freecad/Mod/Test/unittestgui.py 0644L /usr/bin/env freecad.i686: E: wrong-script-interpreter /usr/lib/freecad/Mod/PartDesign/Scripts/Spring.py python freecad.i686: E: non-executable-script /usr/lib/freecad/Mod/PartDesign/Scripts/Spring.py 0644L python freecad.i686: E: wrong-script-end-of-line-encoding /usr/lib/freecad/Mod/PartDesign/Scripts/Spring.py freecad.i686: E: non-executable-script /usr/lib/freecad/Mod/Robot/MovieTool.py 0644L /usr/bin/python freecad.i686: E: wrong-script-end-of-line-encoding /usr/lib/freecad/Mod/Robot/MovieTool.py freecad-data.noarch: W: no-documentation freecad.src:216: W: macro-in-comment %{buildroot} freecad.src:216: W: macro-in-comment %{_libdir} freecad.src:216: W: macro-in-comment %{name} 4 packages and 0 specfiles checked; 50 errors, 7 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint freecad freecad-data freecad-doc freecad.i686: E: explicit-lib-dependency python-matplotlib freecad.i686: E: invalid-soname /usr/lib/freecad/lib/SketcherGui.so SketcherGui.so freecad.i686: W: undefined-non-weak-symbol /usr/lib/freecad/lib/SketcherGui.so Part::BRepOffsetAPI_MakePipeShellPy::add(_object*) freecad.i686: E: invalid-soname /usr/lib/freecad/lib/Robot.so Robot.so freecad.i686: W: undefined-non-weak-symbol /usr/lib/freecad/lib/Robot.so Part::BRepOffsetAPI_MakePipeShellPy::add(_object*) freecad.i686: E: invalid-soname /usr/lib/freecad/lib/PartGui.so PartGui.so freecad.i686: W: undefined-non-weak-symbol /usr/lib/freecad/lib/PartGui.so Part::BRepOffsetAPI_MakePipeShellPy::add(_object*) freecad.i686: E: invalid-soname /usr/lib/freecad/lib/RobotGui.so RobotGui.so freecad.i686: W: undefined-non-weak-symbol /usr/lib/freecad/lib/RobotGui.so Part::BRepOffsetAPI_MakePipeShellPy::add(_object*) freecad.i686: E: invalid-soname /usr/lib/freecad/lib/Complete.so Complete.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/ReverseEngineering.so ReverseEngineering.so freecad.i686: W: undefined-non-weak-symbol /usr/lib/freecad/lib/ReverseEngineering.so Part::BRepOffsetAPI_MakePipeShellPy::add(_object*) freecad.i686: E: invalid-soname /usr/lib/freecad/lib/DrawingGui.so DrawingGui.so freecad.i686: W: undefined-non-weak-symbol /usr/lib/freecad/lib/DrawingGui.so Part::BRepOffsetAPI_MakePipeShellPy::add(_object*) freecad.i686: E: invalid-soname /usr/lib/freecad/lib/Sketcher.so Sketcher.so freecad.i686: W: undefined-non-weak-symbol /usr/lib/freecad/lib/Sketcher.so Part::BRepOffsetAPI_MakePipeShellPy::add(_object*) freecad.i686: E: invalid-soname /usr/lib/freecad/lib/WebGui.so WebGui.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/MeshPart.so MeshPart.so freecad.i686: W: undefined-non-weak-symbol /usr/lib/freecad/lib/MeshPart.so Part::BRepOffsetAPI_MakePipeShellPy::add(_object*) freecad.i686: E: invalid-soname /usr/lib/freecad/lib/Part.so Part.so freecad.i686: W: undefined-non-weak-symbol /usr/lib/freecad/lib/Part.so Part::BRepOffsetAPI_MakePipeShellPy::add(_object*) freecad.i686: E: invalid-soname /usr/lib/freecad/lib/Start.so Start.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/MeshPartGui.so MeshPartGui.so freecad.i686: W: undefined-non-weak-symbol /usr/lib/freecad/lib/MeshPartGui.so Part::BRepOffsetAPI_MakePipeShellPy::add(_object*) freecad.i686: E: invalid-soname /usr/lib/freecad/lib/Points.so Points.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/Drawing.so Drawing.so freecad.i686: W: undefined-non-weak-symbol /usr/lib/freecad/lib/Drawing.so Part::BRepOffsetAPI_MakePipeShellPy::add(_object*) freecad.i686: E: invalid-soname /usr/lib/freecad/lib/libFreeCADApp.so libFreeCADApp.so freecad.i686: W: shared-lib-calls-exit /usr/lib/freecad/lib/libFreeCADApp.so exit@GLIBC_2.0 freecad.i686: E: invalid-soname /usr/lib/freecad/lib/RaytracingGui.so RaytracingGui.so freecad.i686: W: undefined-non-weak-symbol /usr/lib/freecad/lib/RaytracingGui.so Part::BRepOffsetAPI_MakePipeShellPy::add(_object*) freecad.i686: E: invalid-soname /usr/lib/freecad/lib/MeshGui.so MeshGui.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/PointsGui.so PointsGui.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/CompleteGui.so CompleteGui.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/Mesh.so Mesh.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/FreeCADGui.so FreeCADGui.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/Assembly.so Assembly.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/InspectionGui.so InspectionGui.so freecad.i686: W: undefined-non-weak-symbol /usr/lib/freecad/lib/InspectionGui.so Part::BRepOffsetAPI_MakePipeShellPy::add(_object*) freecad.i686: E: invalid-soname /usr/lib/freecad/lib/FreeCAD.so FreeCAD.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/Raytracing.so Raytracing.so freecad.i686: W: undefined-non-weak-symbol /usr/lib/freecad/lib/Raytracing.so Part::BRepOffsetAPI_MakePipeShellPy::add(_object*) freecad.i686: E: invalid-soname /usr/lib/freecad/lib/ImageGui.so ImageGui.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/AssemblyGui.so AssemblyGui.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/libFreeCADGui.so libFreeCADGui.so freecad.i686: W: shared-lib-calls-exit /usr/lib/freecad/lib/libFreeCADGui.so exit@GLIBC_2.0 freecad.i686: E: invalid-soname /usr/lib/freecad/lib/FemGui.so FemGui.so freecad.i686: W: undefined-non-weak-symbol /usr/lib/freecad/lib/FemGui.so Part::BRepOffsetAPI_MakePipeShellPy::add(_object*) freecad.i686: E: invalid-soname /usr/lib/freecad/lib/libFreeCADBase.so libFreeCADBase.so freecad.i686: W: shared-lib-calls-exit /usr/lib/freecad/lib/libFreeCADBase.so exit@GLIBC_2.0 freecad.i686: E: invalid-soname /usr/lib/freecad/lib/QtUnitGui.so QtUnitGui.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/ImportGui.so ImportGui.so freecad.i686: W: undefined-non-weak-symbol /usr/lib/freecad/lib/ImportGui.so Part::BRepOffsetAPI_MakePipeShellPy::add(_object*) freecad.i686: E: invalid-soname /usr/lib/freecad/lib/Fem.so Fem.so freecad.i686: W: undefined-non-weak-symbol /usr/lib/freecad/lib/Fem.so Part::BRepOffsetAPI_MakePipeShellPy::add(_object*) freecad.i686: E: invalid-soname /usr/lib/freecad/lib/ReverseEngineeringGui.so ReverseEngineeringGui.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/Inspection.so Inspection.so freecad.i686: W: undefined-non-weak-symbol /usr/lib/freecad/lib/Inspection.so Part::BRepOffsetAPI_MakePipeShellPy::add(_object*) freecad.i686: E: invalid-soname /usr/lib/freecad/lib/StartGui.so StartGui.so freecad.i686: E: invalid-soname /usr/lib/freecad/lib/Image.so Image.so freecad.i686: E: wrong-script-interpreter /usr/lib/freecad/Mod/PartDesign/Scripts/RadialCopy.py python freecad.i686: E: non-executable-script /usr/lib/freecad/Mod/PartDesign/Scripts/RadialCopy.py 0644L python freecad.i686: E: incorrect-fsf-address /usr/lib/freecad/Mod/Draft/draftlibs/dxfColorMap.py freecad.i686: E: wrong-script-interpreter /usr/lib/freecad/Mod/PartDesign/Scripts/Epitrochoid.py python freecad.i686: E: non-executable-script /usr/lib/freecad/Mod/PartDesign/Scripts/Epitrochoid.py 0644L python freecad.i686: E: non-executable-script /usr/lib/freecad/Mod/Test/unittestgui.py 0644L /usr/bin/env freecad.i686: E: wrong-script-interpreter /usr/lib/freecad/Mod/PartDesign/Scripts/Spring.py python freecad.i686: E: non-executable-script /usr/lib/freecad/Mod/PartDesign/Scripts/Spring.py 0644L python freecad.i686: E: wrong-script-end-of-line-encoding /usr/lib/freecad/Mod/PartDesign/Scripts/Spring.py freecad.i686: E: non-executable-script /usr/lib/freecad/Mod/Robot/MovieTool.py 0644L /usr/bin/python freecad.i686: E: wrong-script-end-of-line-encoding /usr/lib/freecad/Mod/Robot/MovieTool.py freecad-data.noarch: W: no-documentation 3 packages and 0 specfiles checked; 50 errors, 22 warnings. # echo 'rpmlint-done:' Requires -------- freecad (rpmlib, GLIBC filtered): /bin/sh PyQt4 hicolor-icon-theme libCoin.so.40 libGL.so.1 libGLU.so.1 libQtCore.so.4 libQtGui.so.4 libQtNetwork.so.4 libQtOpenGL.so.4 libQtSvg.so.4 libQtWebKit.so.4 libQtXml.so.4 libSMDS.so.5.1 libSMESH.so.5.1 libSMESHDS.so.5.1 libSoQt.so.20 libStdMeshers.so.5.1 libTKBO.so.8 libTKBRep.so.8 libTKBool.so.8 libTKCAF.so.8 libTKFillet.so.8 libTKG2d.so.8 libTKG3d.so.8 libTKGeomAlgo.so.8 libTKGeomBase.so.8 libTKHLR.so.8 libTKIGES.so.8 libTKLCAF.so.8 libTKMath.so.8 libTKMesh.so.8 libTKOffset.so.8 libTKPrim.so.8 libTKSTEP.so.8 libTKSTEPAttr.so.8 libTKSTEPBase.so.8 libTKSTL.so.8 libTKShHealing.so.8 libTKTopAlgo.so.8 libTKXCAF.so.8 libTKXDEIGES.so.8 libTKXDESTEP.so.8 libTKXSBase.so.8 libTKernel.so.8 libboost_program_options.so.1.54.0 libboost_regex.so.1.54.0 libboost_signals.so.1.54.0 libboost_system.so.1.54.0 libc.so.6 libdl.so.2 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libgcc_s.so.1(GCC_3.4) libm.so.6 libpython2.7.so.1.0 libspnav.so.0 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(CXXABI_1.3.1) libxerces-c-3.1.so libz.so.1 libzipios.so.0 python-collada python-matplotlib python-pivy rtld(GNU_HASH) freecad-data (rpmlib, GLIBC filtered): freecad freecad-doc (rpmlib, GLIBC filtered): freecad qt-assistant Provides -------- freecad: application() application(freecad.desktop) freecad freecad(x86-32) mimehandler(application/x-extension-fcstd) freecad-data: freecad-data freecad-doc: freecad-doc Unversioned so-files -------------------- freecad: /usr/lib/freecad/Mod/PartDesign/PartDesign.so freecad: /usr/lib/freecad/Mod/PartDesign/PartDesignGui.so freecad: /usr/lib/freecad/lib/Assembly.so freecad: /usr/lib/freecad/lib/AssemblyGui.so freecad: /usr/lib/freecad/lib/Complete.so freecad: /usr/lib/freecad/lib/CompleteGui.so freecad: /usr/lib/freecad/lib/Drawing.so freecad: /usr/lib/freecad/lib/DrawingGui.so freecad: /usr/lib/freecad/lib/Fem.so freecad: /usr/lib/freecad/lib/FemGui.so freecad: /usr/lib/freecad/lib/FreeCAD.so freecad: /usr/lib/freecad/lib/FreeCADGui.so freecad: /usr/lib/freecad/lib/Image.so freecad: /usr/lib/freecad/lib/ImageGui.so freecad: /usr/lib/freecad/lib/ImportGui.so freecad: /usr/lib/freecad/lib/Inspection.so freecad: /usr/lib/freecad/lib/InspectionGui.so freecad: /usr/lib/freecad/lib/Mesh.so freecad: /usr/lib/freecad/lib/MeshGui.so freecad: /usr/lib/freecad/lib/MeshPart.so freecad: /usr/lib/freecad/lib/MeshPartGui.so freecad: /usr/lib/freecad/lib/Part.so freecad: /usr/lib/freecad/lib/PartGui.so freecad: /usr/lib/freecad/lib/Points.so freecad: /usr/lib/freecad/lib/PointsGui.so freecad: /usr/lib/freecad/lib/QtUnitGui.so freecad: /usr/lib/freecad/lib/Raytracing.so freecad: /usr/lib/freecad/lib/RaytracingGui.so freecad: /usr/lib/freecad/lib/ReverseEngineering.so freecad: /usr/lib/freecad/lib/ReverseEngineeringGui.so freecad: /usr/lib/freecad/lib/Robot.so freecad: /usr/lib/freecad/lib/RobotGui.so freecad: /usr/lib/freecad/lib/Sketcher.so freecad: /usr/lib/freecad/lib/SketcherGui.so freecad: /usr/lib/freecad/lib/Start.so freecad: /usr/lib/freecad/lib/StartGui.so freecad: /usr/lib/freecad/lib/WebGui.so freecad: /usr/lib/freecad/lib/libFreeCADApp.so freecad: /usr/lib/freecad/lib/libFreeCADBase.so freecad: /usr/lib/freecad/lib/libFreeCADGui.so Source checksums ---------------- http://downloads.sourceforge.net/free-cad/freecad-0.13.1830.tar.gz : CHECKSUM(SHA256) this package : 550ed16225e4cd67a463ae9b826f3a64edf7d2819cc8d235b15a89e10be72f13 CHECKSUM(SHA256) upstream package : 550ed16225e4cd67a463ae9b826f3a64edf7d2819cc8d235b15a89e10be72f13 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review --rpm-spec -n /tmp/freecad-0.13-5.fc20.src.rpm -m fedora-rawhide-i386 Buildroot used: fedora-rawhide-i386 Active plugins: Python, Generic, Shell-api, C/C++ Disabled plugins: Java, SugarActivity, fonts, Haskell, Ocaml, Perl, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review