https://bugzilla.redhat.com/show_bug.cgi?id=1089425 --- Comment #9 from Peter Oliver <mavit@xxxxxxxxxxxx> --- (In reply to Christopher Meng from comment #7) > How could this get approved? This sounds like it might be intended to be an insult, aimed at the packager and/or the reviewer. Please try to avoid discouraging contributions. > 1. python -c 'import archmod.CHM; > archmod.CHM.CHMDir("Docs").process_templates("Docs/Chm")' > > At least you need to use python macro %{__python2}. > > 2. %files -n %{name}-doc > > Why not use "%files doc" directly? > > 3. %{_mandir}/man1/%{name}.1.gz > > You should list it as: > > %{_mandir}/man1/%{name}.1* Fixed all these. Thanks for picking up on them. > 4. %{_datadir}/mime > %{_datadir}/icons/hicolor > > Completely wrong, please add requires on hicolor-icon-theme. Well that would have been my instinct until I read https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function, but, fancy that, hicolor-icon-theme contains only directories, not icons. Thanks again. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review