Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: sendmail https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226407 ------- Additional Comments From paul@xxxxxxxxxxxx 2007-04-13 13:11 EST ------- rpmlint output, ignoring things explained away in Comment #2. W: sendmail unversioned-explicit-provides MTA => I'm not convinced about the merits of "Provides: MTA" vs. "Provides: smtpdaemon", and the discussion on fedora-devel-list didn't seem to lead to any particular conclusion. It's harmless enough though so I'm not going to quibble about it. E: sendmail hardcoded-library-path in /usr/lib/sendmail => This comes from "Provides: /usr/lib/sendmail", is intentional and required for backwards compatibility (OK). W: sendmail unversioned-explicit-provides %{_sysconfdir}/pam.d/smtp W: sendmail unversioned-explicit-provides %{_mandir}/man8/sendmail.8.gz == Provides for alternatives-based files (OK). W: sendmail mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 232) => Should use either spaces or tabs consistently, not a mixture of the two. E: sendmail non-standard-executable-perm /usr/sbin/makemap 0555 => Permission should be 0755 to enable debuginfo extraction. E: sendmail non-readable /etc/aliases.db 0640 => This has appeared because the original package explicitly used %attr(0644... for this file. Harmless because (a) the file is %ghosted and (b) the permissions will be 0640 on the installed system anyway if the file is created properly. E: sendmail executable-marked-as-config-file /etc/rc.d/init.d/sendmail => Marking initscripts as %config is a contentious subject. I'm against it on the basis that configurability should be encapsulated in /etc/sysconfig/sendmail etc. but I can see the merits of the argument the other way too. Do you have a strong opinion on this or is this just an inheritance from older packaging? E: sendmail non-standard-executable-perm /usr/sbin/smrsh 0555 => Permission should be 0755 to enable debuginfo extraction. E: sendmail postin-without-chkconfig /etc/rc.d/init.d/sendmail => /sbin/chkconfig --add sendmail was removed from %post along with the stuff for upgrading from old versions, needs to be reinstated. Other comments: FFR_UNSAFE_SASL still present in sasl2 config - why? Why is the not-included mysql support stuff still in the spec? Any thoughts on my suggestion for the %post script near the end of Comment #9? Finally, the line containing "MSPQOWN=${nameuser}" in the spec has a trailing space on it. Please remove it, it's been annoying me for ages ;-) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review