[Bug 1077794] Review Request: copr-frontend - Frontend for Copr

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1077794



--- Comment #4 from Miroslav Suchý <msuchy@xxxxxxxxxx> ---
> - Pre-installation scriptlet fails. There is a missing R package.
>   Add 'passwd' as Requires package.

fixed

> - Remove 'make' as BR package.

fixed

> - 'copr-frontend-doc' is a standalone package for documentation files.
> It must be a noarch package and must be provided by an own LICENSE file.

fixed

> - '/usr/share/doc/copr-frontend' is not owned.

fixed

> - ... %{_arch} == "x86_64" 
> Usually I use this form
> if [ %{__isa_bits} = "64" ]; then

I rather prefer the first notation.

> - Same error repeats during make's operations:
>  Error: ImportError: No module named alembic (line 13)
This is from epydoc when generating documentation, when it try to evaluate the
code. It is harmless as doc for those 3rd party modules are not generated
anyway.
To get rid I would have to copy all BR to R, which I hesitate to do, as it is
really not needed.


>- Large documentation must go in a -doc subpackage. Large could be size (~1MB)
>  or number of files.
>  Note: Documentation size is 5509120 bytes in 294 files.
>  See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation
This is bug of rpm, see bug 728959 and 1078760.

Updated:
Spec URL: http://miroslav.suchy.cz/copr/copr-frontend.spec
SRPM URL: http://miroslav.suchy.cz/copr/copr-frontend-1.36-1.fc20.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]