[Bug 1080201] Review Request: perl-Catalyst-View-GD - A Catalyst View for GD images

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1080201



--- Comment #6 from Petr Šabata <psabata@xxxxxxxxxx> ---
Ok, you're missing some buildtime dependencies...

Those are required by the test suite itself:
perl(base)
perl(Catalyst)
perl(Catalyst::Test)
perl(FindBin)
perl(File::Spec)
perl(lib)
perl(strict)
perl(warnings)

And in addition to that, those are required by the tested code:
perl(Catalyst::Exception)
perl(Catalyst::View)
perl(NEXT)
perl(Scalar::Util)

And you should remove Catalyst::Runtime.  This module isn't directly used
anywhere.  Require the specific modules from the suite which I listed above
instead.  This prevents future FTBFS breakage if the modules move to a
different bundle.

Also, drop the Module::Build dependency.  You're using Makefile.PL which
doesn't need it.

And finally drop the explicit GD runtime dependency (line 19).  This is
automatically discovered and added by rpmbuild.

The rest of the spec looks good and the license is fine too.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]