[Bug 1079749] Review Request: perl-Test-Image-GD - A module for testing images using GD

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1079749

Petr Šabata <psabata@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #11 from Petr Šabata <psabata@xxxxxxxxxx> ---
Ok, I'm going to approve this.

However, you've just added yet another BR entry for File::Spec while, in fact,
you don't need any; the code only requires File::Spec::Functions (which you
already list), despite what Makefile.PL says.
Drop both of the File::Spec BRs before pushing.

I suggest sorting the dependency list so you don't overlook things like this
next timne.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]