[Bug 1089425] Review Request: keepass - Password manager

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1089425

Christopher Meng <i@xxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |i@xxxxxxxx



--- Comment #7 from Christopher Meng <i@xxxxxxxx> ---
How could this get approved?

1. python -c 'import archmod.CHM;
archmod.CHM.CHMDir("Docs").process_templates("Docs/Chm")'


At least you need to use python macro %{__python2}.

2. %files -n %{name}-doc

Why not use "%files doc" directly?

3. %{_mandir}/man1/%{name}.1.gz

You should list it as:

%{_mandir}/man1/%{name}.1*

4. %{_datadir}/mime
%{_datadir}/icons/hicolor

Completely wrong, please add requires on hicolor-icon-theme.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]