[Bug 1089213] Review Request: openstack-trove - OpenStack DBaaS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1089213

Alan Pevec <apevec@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |p@xxxxxxxxxxxxxx
              Flags|                            |needinfo?(p@xxxxxxxxxxxxxx)



--- Comment #4 from Alan Pevec <apevec@xxxxxxxxxx> ---
There are rpmlint errors, comments inline (ignoring bogus speling erors
reports):

> openstack-trove-common.noarch: W: non-standard-gid /etc/trove/trove.conf trove
> openstack-trove-common.noarch: W: non-standard-uid /var/run/trove trove
> openstack-trove-common.noarch: W: non-standard-uid /var/lib/trove trove
> openstack-trove-common.noarch: W: non-standard-gid /var/lib/trove trove
> openstack-trove-common.noarch: W: non-standard-uid /var/log/trove trove

Those can be ignored, "trove" group is created in %pre

> openstack-trove-common.noarch: E: non-readable /etc/trove/trove.conf 0640L

Ignore, trove.conf is readable by the "trove" group

> openstack-trove-common.noarch: E: incoherent-logrotate-file /etc/logrotate.d/openstack-trove

Move to the main package to make rpmlint happy?
http://fedoraproject.org/wiki/Common_Rpmlint_issues#incoherent-logrotate-file

> openstack-trove-common.noarch: W: no-manual-page-for-binary trove-mgmt-taskmanager
> openstack-trove-common.noarch: W: no-manual-page-for-binary trove-manage
> openstack-trove-api.noarch: W: no-manual-page-for-binary trove-api
> openstack-trove-taskmanager.noarch: W: no-manual-page-for-binary trove-taskmanager
> openstack-trove-conductor.noarch: W: no-manual-page-for-binary trove-conductor

Please report upstream!

> openstack-trove-api.noarch: W: no-documentation

Bogus, docs are in subpackage!

> openstack-trove-api.noarch: W: only-non-binary-in-usr-lib

Side-effect of below? vvv

> openstack-trove-api.noarch: E: script-without-shebang /usr/lib/systemd/system/openstack-trove-api.service

Removing x bit from .service (same in -taskmanager -conductor -guestagent
subpackages) could help unconfuse rpmlint?

> python-trove.noarch: E: explicit-lib-dependency python-httplib2
> python-trove.noarch: E: explicit-lib-dependency python-passlib

Bogus!

> python-trove.noarch: W: summary-not-capitalized C trove Python libraries

-Summary:          %{project} Python libraries
+Summary:          Python libraries for OpenStack %{project}

> python-trove.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/trove/db/sqlalchemy/migrate_repo/manage.py 0644L /usr/bin/env

Remove first line #!/usr/bin/env python (same for other reports of this:
fakemode.py conductor.py manage.py guest.py taskmanager.py api.py
rpc/__init__.py )

> python-trove.noarch: E: zero-length /usr/lib/python2.7/site-packages/trove/templates/mongodb/override.config.template

This is empty upstream, not sure why? (repeated for
redis/override.config.template)

> openstack-trove.src: E: specfile-error warning: bogus date in %changelog: Sun Apr 25 2014 Pádraig Brady <pbrady@xxxxxxxxxx> - 2014.1-2

Don't work over midnight and over weekends :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]