[Bug 1079732] Review Request: perl-Catalyst-Plugin-CustomErrorMessage - Catalyst plugin to have more cute error message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1079732

David Dick <ddick@xxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED



--- Comment #6 from David Dick <ddick@xxxxxxxx> ---
Hi Sven,

The following patch file (and comments) shows work to do on this spec file

--- perl-Catalyst-Plugin-CustomErrorMessage.old 2014-04-21 23:42:28.000000000
+1000
+++ perl-Catalyst-Plugin-CustomErrorMessage.proposed    2014-05-20
21:40:53.844909346 +1000
@@ -8,6 +8,8 @@
 Source0:       
http://search.cpan.org/CPAN/authors/id/J/JK/JKUTEJ/Catalyst-Plugin-CustomErrorMessage-%{version}.tar.gz
 BuildArch:      noarch
 BuildRequires:  perl
+BuildRequires:  perl(base) 
+BuildRequires:  perl(English)
 BuildRequires:  perl(Test::More)
 BuildRequires:  perl(ExtUtils::MakeMaker)
 BuildRequires:  perl(Carp::Clan)
@@ -15,7 +17,14 @@
 BuildRequires:  perl(Class::Data::Inheritable)
 BuildRequires:  perl(HTML::Entities)
 BuildRequires:  perl(MRO::Compat)
+BuildRequires:  perl(Pod::Coverage)
+BuildRequires:  perl(strict)
+BuildRequires:  perl(Test::Distribution)
+BuildRequires:  perl(Test::Pod)
+BuildRequires:  perl(Test::Pod::Coverage)
 BuildRequires:  perl(URI::Escape)
+BuildRequires:  perl(warnings)
+Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo
$version))

 %description
 Catalyst::Plugin::CustomErrorMessage is a Catalyst Plugin that provides
@@ -39,8 +48,7 @@
 %files
 %{perl_vendorlib}/*
 %{_mandir}/man3/*
-%doc Changes
-%doc README
+%doc Changes README

 %changelog
 * Sun Apr 06 2014 Sven Nierlein <sven.nierlein@xxxxxxxxx> 0.06-2

Justifications follow

MUST FIX;

perl(base) is required at line 36 of lib/Catalyst/Plugin/CustomErrorMessage.pm
perl(English) is required at line 9 of
t/01-Catalyst-Plugin-CustomErrorMessage.t
perl(Pod::Coverage) is required in t/pod-coverage.t
perl(strict) is required at line 42 of
lib/Catalyst/Plugin/CustomErrorMessage.pm
perl(Test::Distribution) is required at line 3 of t/00-distribution.t
perl(Test::Pod) is required at line 9 of t/pod.t
perl(Test::Pod::Coverage) is required at line 7 of t/pod-coverage.t
perl(warnings) is required at line 43 of
lib/Catalyst/Plugin/CustomErrorMessage.pm

OPTIONAL;

The multiple %doc lines can safely be rolled into one line.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]