[Bug 1099267] Review Request: drupal7-addressfield - Address Field defines a new field type to store intl addresses

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1099267



--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ Package builds successful in F21 x86_64 mock

+ rpmlint on generated rpms gave
drupal7-addressfield.noarch: W: spelling-error Summary(en_US) intl -> int,
lint, into
drupal7-addressfield.noarch: W: spelling-error %description -l en_US xNAL ->
anal
drupal7-addressfield.src: W: spelling-error Summary(en_US) intl -> int, lint,
into
drupal7-addressfield.src: W: spelling-error %description -l en_US xNAL -> anal
2 packages and 0 specfiles checked; 0 errors, 4 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball: 37bfea1d918e84a5cfafde7124d667fdd16a0cd29b5dcaea9a84ce941fdb203e
upstream tarball :
37bfea1d918e84a5cfafde7124d667fdd16a0cd29b5dcaea9a84ce941fdb203e

+ License is valid GPLv2+ and included in its own text file LICENSE.txt

+ Package follows drupal7 packaging guidelines

Suggestions:
1) Group tag is not necessary in Fedora now and can be removed from spec file.
See https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag

2) change the 
Summary: Address Field defines a new field type to store intl addresses
to
Summary: Address Field defines a new field type to store international postal
addresses

and change the same in this review summary.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]