[Bug 1099166] Review Request: screenfetch - Display system information

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1099166



--- Comment #4 from Martín Buenahora <martinbuenahora@xxxxxxxxxxxxxxx> ---
(In reply to Eduardo Echeverria from comment #3)
> Hi Martin. 
> 
> As said @Jason, some tags are specifically EPEL5's dependents, please don't
> use it. refer to epel packaging guidelines for further details (It is
> important to note that epel6 guidelines are the same of fedora)
> https://fedoraproject.org/wiki/EPEL:Packaging.
> 
> This is a snapshot or stable release? if is a snapshot, check this
> guidelines
> https://fedoraproject.org/wiki/Packaging:NamingGuidelines?rd=Packaging/
> NamingGuidelines#Snapshot_packages
> 
> If you not have anything to build in %build section, put it a comment as
> "Nothing to build" there 
> 
> I think that screenfetch-dev it is not a good name for an "binary", I
> recommend rename it.
> 
> From my POW, bash not should be a explicit requirement, due to is the
> default in fedora and other linux distributions. 
> 
> For now, I will take this, I'm waiting your fixes soon. :)

Ok, thank you.

I think the "screenfetch-dev" file must be linked to "screenfetch". I think
that's better than renaming the file itself, because it makes easier to
maintain.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]