https://bugzilla.redhat.com/show_bug.cgi?id=1097943 --- Comment #3 from Mohamed El Morabity <pikachu.2014@xxxxxxxxx> --- Github provides a convenient way to retrieve online a source tarball for a given commit: %global git_hash 031f69bd8844af38dac78f403c197bcb96c9a43a %global short_git_hash %%(c=%%{git_hash}; echo ${c:0:7}) [...] Source: https://github.com/FernetMenta/vdr-plugin-vnsiserver/archive/%{short_git_hash}/%{name}-%{short_git_hash}.tar.gz [...] %prep %setup -q -n vdr-plugin-vnsiserver-%{git_hash} By the way, upstream has just released two days ago a new 1.1.0 release (see https://github.com/FernetMenta/vdr-plugin-vnsiserver/commit/7d4aa813cc54431151e9120f2080f00251e9cf48). Notice that no tag was created for this release on Github. You should ask upstream to create a tag for further release, to make easier packaging and updates tracking. It looks like upstream also improved well the way the plugin is build and deployed through Makefile. As a result, the %build and %install sections can be simplified as below: %build make %{?_smp_mflags} CFLAGS="-fPIC %optflags" CXXFLAGS="-fPIC %{optflags}" %install %make_install install -dm 755 %{buildroot}%{vdr_configdir}/plugins/%{plugin_name} install -Dpm 644 %{plugin_name}/* %{buildroot}%{vdr_configdir}/plugins/%{plugin_name}/ I really wonder if it's worth naming the package vdr-vnsiserver5: - the project name doesn't refer anymore to the protocol version (see https://github.com/FernetMenta/vdr-plugin-vnsiserver/commit/6ff29b7149a1a522804c0cd1877f1d2b5148d4d2) - upstream officialy published about the protocol stabilization, and the renaming from vdr-vnsiserver5 to vdr-vnsiserver (see http://forum.xbmc.org/showthread.php?tid=189793). As a result, you should rename the package to vdr-vnsiserver. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review