[Bug 1058587] Review Request: drawpile - A collaborative drawing program

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1058587



--- Comment #15 from Pavel Alexeev (aka Pahan-Hubbitus) <pahan@xxxxxxxxxxxxx> ---
(In reply to Christopher Meng from comment #14)
> (In reply to Pavel Alexeev (aka Pahan-Hubbitus) from comment #13)
> > (In reply to Christopher Meng from comment #12)
> > > (In reply to Pavel Alexeev (aka Pahan-Hubbitus) from comment #10)
> > > Yes, because you are deleting source files. These files have no licensing
> > > issues. Don't get muddled.
> > > 
> > > Quoted(https://github.com/callaa/Drawpile/issues/51#issuecomment-42953986):
> > Yes, no licensing consideration at all. That files have bundling issue.
> > http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries
> 
> No.
Why not??
> 
> > I have seen author answer.
> > 
> > > ************************************************************
> > > Here's a little more detail about the bundled files:
> > > 
> > > qcommandlineparser: safe to delete (used only for Qt 5.0 compatibility)
> > Then delete.
> > > qzip: these are Qt internals, which are not exported. Applications must
> > > bundle them to use them directly.
> > You may work with upstream to export need symbols or request exception:
> > http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Exceptions
> 
> You should ask Qqt upstream but not me to do that. I can't control this.
I shouldn't anything. If you prefer help author to do so you may be involved in
that process.

> > > kis_cubic_curve: this is taken from Krita's source code and is not a part of
> > In this case Krita should be packaged, imported in Fedora and then appeared
> > there as Dependency. If you are speak about calibra-krita it is already in
> > Fedora and calligra-krita-libs should be used for shared linking.
> > 
> > Etc...
> 
> I don't think it's a bundled library, it's just a piece of code taken from
> other projects. Krita is already packaged, but I don't agree with your
> opinion of hacking and depending on calligra-krita-libs.

There nothing to agree or disagree with me. It is Fedora guidelines. I can't
say I fully agree with it (but mostly yes). If you disagree with it, you may
start process of changing it.

> I don't want to waste any time here anymore, if you still consider that it
> has bundled libraries, I will close this review.
Yes, I think. If you doubt I'm right in conclusion you may forward that
question in ML of FPC ticket to resolve issue.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]