https://bugzilla.redhat.com/show_bug.cgi?id=1076186 --- Comment #5 from David King <amigadave@xxxxxxxxxxxxx> --- (In reply to Ankur Sinha (FranciscoD) from comment #4) >… > Please inform upstream of the wrong address. Sadly, upstream is no longer maintaining OpenSTV as Free Software. This is the last version using the GPL. > [?] License files included in package %docs if included in source package > The License isn't installed as a doc. It's installed with the rest of the > python files. Does it need to be placed there for functioning of the > software? > Otherwise, please consider shifting it to docdir. There is a menu item in OpenSTV which shows the license: Help->License, so it needs to be installed with the rest of the Python files for the package to function correctly. Should I also add a symlink to /usr/shar/doc/openstv/COPYING (or similar)? > [?] Functions as described (e.g. no crashes) > Not tested. Please ensure it works. Yes, tested with the sample data and it works fine. :-) > [?] Spec uses macros consistently > You've used $RPM_BUILD_ROOT at one location. Consider changing it to > buildroot, > for consistency. Thanks, fixed! > [?] Patches have appropriate commentary > Please comment the patch. The patch itself has a comment, but I have now added this to the spec file as well. > Not many issues. Just cosmetics primarily. Can I please request you to > include > and install an appdata file in the package for gnome-software? Thanks for the recommendation. I have included an AppData file along with the other changes. Spec URL: http://amigadave.fedorapeople.org/openstv.spec SRPM URL: http://amigadave.fedorapeople.org/openstv-1.7-1.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review