[Bug 1058587] Review Request: drawpile - A collaborative drawing program

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1058587



--- Comment #12 from Christopher Meng <i@xxxxxxxx> ---
(In reply to Pavel Alexeev (aka Pahan-Hubbitus) from comment #10)
> It must be similar to:
> rm -rfv src/client/ora/zip*.h
> rm -rfv src/client/ora/qzip.h
> instead of:
> rm -rfv ora/zip*.h
> rm -rfv ora/qzip.h

My bad, I was very busy and hadn't saved the changes before uploading.


> And then build failed with
> (http://koji.fedoraproject.org/koji/taskinfo?taskID=6841337):
> + /usr/bin/cmake -DCMAKE_C_FLAGS_RELEASE:STRING=-DNDEBUG
> -DCMAKE_CXX_FLAGS_RELEASE:STRING=-DNDEBUG
> -DCMAKE_Fortran_FLAGS_RELEASE:STRING=-DNDEBUG
> -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON -DCMAKE_INSTALL_PREFIX:PATH=/usr
> -DINCLUDE_INSTALL_DIR:PATH=/usr/include -DLIB_INSTALL_DIR:PATH=/usr/lib64
> -DSYSCONF_INSTALL_DIR:PATH=/etc -DSHARE_INSTALL_PREFIX:PATH=/usr/share
> -DLIB_SUFFIX=64 -DBUILD_SHARED_LIBS:BOOL=ON -DCLIENT=ON -DSERVER=ON
> CMake Error at src/client/CMakeLists.txt:195 (add_executable):
>   Cannot find source file:
> 
>     utils/kis_cubic_curve.cpp
> 
> Files without copyrights for clarification:
> 1) ./src/client/widgets/dualcolorbutton/plugin.cpp
> 2) ./src/client/widgets/gradientslider/plugin.cpp
> 3) ./src/client/widgets/colorbutton/plugin.cpp
> 4) ./src/client/widgets/imageselector/plugin.cpp
> 5) ./src/client/widgets/brushpreview/plugin.cpp

Yes, because you are deleting source files. These files have no licensing
issues. Don't get muddled.

Quoted(https://github.com/callaa/Drawpile/issues/51#issuecomment-42953986):

************************************************************
Here's a little more detail about the bundled files:

qcommandlineparser: safe to delete (used only for Qt 5.0 compatibility)
qzip: these are Qt internals, which are not exported. Applications must bundle
them to use them directly.
kis_cubic_curve: this is taken from Krita's source code and is not a part of Qt
or any library Drawpile depends on.
qtcolortriangle: this is not part of Qt itself, but from the (now defunct) Qt
Solutions package.
I'll add the copyright headers to the plugin files. (The plugins are not
normally installed. They are used only during development and must be installed
manually if needed.)
************************************************************

Therefore I will only do this:

rm -rfv src/server/qcommandline*

SPEC URL: http://misc.cicku.me/fedora/drawpile.spec
SRPM URL: http://misc.cicku.me/fedora/drawpile-0.9.0-2.fc21.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]