[Bug 1090933] Review Request : fusioninventory-agent

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1090933



--- Comment #3 from Michael Schwendt <bugs.michael@xxxxxxx> ---
Compared with the last official build in koji,

  http://koji.fedoraproject.org/koji/packageinfo?packageID=12285

you've introduced several packaging mistakes related to "unowned directories"
and duplicated files:

 
https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership
  https://fedoraproject.org/wiki/Packaging:UnownedDirectories

The subpackage inter-dependencies are not trivial, so let's see:

  %files -n perl-FusionInventory-Agent
  %doc Changes LICENSE THANKS
  %{_datadir}/fusioninventory

The last line in this %files list includes the directory
/usr/share/fusioninventory *and* everything in it. That means it includes also
the files and subdirs specified in the subpackages -task-esx, -task-network,
-task-deploy and -task-inventory. Example:

  %files task-esx
  %{_bindir}/fusioninventory-esx
  %{_mandir}/man1/fusioninventory-esx.1*
  %{_datadir}/fusioninventory/lib/FusionInventory/Agent/Task/ESX.pm
  %{_datadir}/fusioninventory/lib/FusionInventory/Agent/SOAP

One way to avoid that is to either %exclude all those files (included in the
subpackages already) in the perl-FusionInventory-Agent package. Or be more
specific about what to include in the perl-FusionInventory-Agent package based
on including only the %dir

  %files -n perl-FusionInventory-Agent
  %doc Changes LICENSE THANKS
  %dir %{_datadir}/fusioninventory
  ...add specific files and needed %dir entries here...

Note that there are a various subdirs in paths such as
%{_datadir}/fusioninventory/lib/FusionInventory/Agent/Task/, which must not be
"unowned".


A related hint: To increase readability of directory entries in %files lists,
many packagers append a trailing slash to emphasize that the entry is for a
directory tree and not a single file:

  %{_datadir}/somedirectory/


[...]

Your %changelog refers to 2.3.6-1 but the spec file is 2.3.6-0:

  Version:     2.3.6
  Release:     0%{?dist}

Consider pointing the fedora-review tool at this ticket (run "fedora-review -b
1090933") to let it perform many tests not limited to running rpmlint on all
packages.


> find %{buildroot} -type d -depth -exec rmdir {} 2>/dev/null ';'

Not needed anymore for many years.


> %files
> /%{_bindir}/fusioninventory-injector

Why the leading slash?

  $ rpm -E %_bindir
  /usr/bin

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]