https://bugzilla.redhat.com/show_bug.cgi?id=1087742 Pavel Alexeev (aka Pahan-Hubbitus) <pahan@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pahan@xxxxxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |pahan@xxxxxxxxxxxxx Flags| |fedora-review? --- Comment #1 from Pavel Alexeev (aka Pahan-Hubbitus) <pahan@xxxxxxxxxxxxx> --- ===== MUST items ===== Generic: [!]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing does not list just ASL, only ASL 1.0, ASL 1.1, ASL 2.0 present. Needs clarification. [!x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required Other cleanup also required if it is not targeted to EL-5. On import stage if you are prefer. ===== SHOULD items ===== [!]: Package consistently uses macros (instead of hard-coded directory names). %setup -q -c -T tar xif %{SOURCE0} Should be just %setup… [!]: Packages should try to preserve timestamps of original installed files. Please preserve timestamp on package.xml mangled in %prep. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review