[Bug 1092022] Review Request: rubygem-drake - A branch of Rake supporting automatic parallelizing of tasks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1092022



--- Comment #1 from Jan Pradac <jan.pradac@xxxxxxxxx> ---
Please check rpmlint issue:
- rubygem-drake.noarch: E: script-without-shebang
/usr/share/gems/gems/drake-0.9.2.0.3.1/lib/rake/ruby182_test_unit_fix.rb

Please do not run tests by itself (drake):
- ./bin/drake test

Installation verified manually with installed rubygem-comp_tree.


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: There is no build directory. Running licensecheck on vanilla
     upstream sources. No licenses found. Please check the source files for
     licenses manually.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/gems,
     /usr/share/gems/doc
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 40960 bytes in 5 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Ruby:
[x]: Platform dependent files must all go under %{gem_extdir_mri}, platform
     independent under %{gem_dir}.
[x]: Gem package must not define a non-gem subpackage
[x]: Macro %{gem_extdir} is deprecated.
[x]: Gem package is named rubygem-%{gem_name}
[x]: Package contains BuildRequires: rubygems-devel.
[x]: Gem package must define %{gem_name} macro.
[x]: Pure Ruby package must be built as noarch
[x]: Package does not contain Requires: ruby(abi).
[x]: Package contains Requires: ruby(release).

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

Ruby:
[x]: Specfile should use macros from rubygem-devel package.
     Note: The specfile doesn't use these macros: %{gem_spec}, %doc
     %{gem_docdir}, %exclude %{gem_cache}
[x]: Gem package should exclude cached Gem.
[x]: Gem should use %gem_install macro.
[x]: Test suite of the library should be run.

===== EXTRA items =====

Generic:
[!]: Rpmlint is run on all installed packages.
     Note: Mock build failed
     See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint
[x]: Spec file according to URL is the same as in SRPM.


Installation errors
-------------------
INFO: mock.py version 1.1.38 starting...
Start: init plugins
INFO: selinux enabled
Finish: init plugins
Start: run
Mock Version: 1.1.38
INFO: Mock Version: 1.1.38
Start: lock buildroot
INFO: installing package(s):
/home/bredy/1092022-rubygem-drake/results/rubygem-drake-0.9.2.0.3.1-1.fc20.noarch.rpm
/home/bredy/1092022-rubygem-drake/results/rubygem-drake-doc-0.9.2.0.3.1-1.fc20.noarch.rpm
ERROR: Command failed: 
 # ['/usr/bin/yum', '--installroot', '/var/lib/mock/fedora-20-x86_64/root/',
'--releasever', '20', 'install',
'/home/bredy/1092022-rubygem-drake/results/rubygem-drake-0.9.2.0.3.1-1.fc20.noarch.rpm',
'/home/bredy/1092022-rubygem-drake/results/rubygem-drake-doc-0.9.2.0.3.1-1.fc20.noarch.rpm',
'--setopt=tsflags=nocontexts']
Chyba: Balíček: rubygem-drake-0.9.2.0.3.1-1.fc20.noarch
(/rubygem-drake-0.9.2.0.3.1-1.fc20.noarch)
           Vyžaduje: rubygem(comp_tree)
 Pro obejití problému můžete zkusit volbu --skip-broken
 Můžete zkusit spustit: rpm -Va --nofiles --nodigest



Rpmlint
-------
Checking: rubygem-drake-0.9.2.0.3.1-1.fc20.noarch.rpm
          rubygem-drake-doc-0.9.2.0.3.1-1.fc20.noarch.rpm
          rubygem-drake-0.9.2.0.3.1-1.fc20.src.rpm
rubygem-drake.noarch: W: spelling-error Summary(en_US) parallelizing ->
paralleling, paralyzing, palatalizing
rubygem-drake.noarch: W: spelling-error %description -l en_US parallelizing ->
paralleling, paralyzing, palatalizing
rubygem-drake.noarch: E: script-without-shebang
/usr/share/gems/gems/drake-0.9.2.0.3.1/lib/rake/ruby182_test_unit_fix.rb
rubygem-drake.noarch: W: no-manual-page-for-binary drake
rubygem-drake-doc.noarch: W: no-documentation
rubygem-drake.src: W: spelling-error Summary(en_US) parallelizing ->
paralleling, paralyzing, palatalizing
rubygem-drake.src: W: spelling-error %description -l en_US parallelizing ->
paralleling, paralyzing, palatalizing
3 packages and 0 specfiles checked; 1 errors, 6 warnings.




Requires
--------
rubygem-drake (rpmlib, GLIBC filtered):
    /usr/bin/env
    /usr/bin/ruby
    ruby(release)
    rubygem(comp_tree)
    rubygems

rubygem-drake-doc (rpmlib, GLIBC filtered):
    rubygem-drake



Provides
--------
rubygem-drake:
    rubygem(drake)
    rubygem-drake

rubygem-drake-doc:
    rubygem-drake-doc



Source checksums
----------------
http://rubygems.org/downloads/drake-0.9.2.0.3.1.gem :
  CHECKSUM(SHA256) this package     :
4f7983a69720d6cc3427a137b31b0737b63033d96d80d8dbb4ad360e75abf325
  CHECKSUM(SHA256) upstream package :
4f7983a69720d6cc3427a137b31b0737b63033d96d80d8dbb4ad360e75abf325


Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/usr/bin/fedora-review -b 1092022
Buildroot used: fedora-20-x86_64
Active plugins: Generic, Ruby, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl,
Haskell, R, PHP
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]