[Bug 1092018] Review Request: rubygem-comp_tree - A simple framework for automatic parallelism

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1092018



--- Comment #4 from Lubomir Rintel <lkundrak@xxxxx> ---
(In reply to Jan Pradac from comment #3)
> Issues:
> =======
> - gems should require rubygems package
>   Note: Requires: rubygems missing in rubygem-comp_tree-doc
>   See: http://fedoraproject.org/wiki/Packaging:Ruby#RubyGems

No. The main package already requires rubygems and the -doc subpackage depends
on the main package, therefore it transitively drags in rubygems. No problem
here.

>   - hint - probably needed "%doc %{gem_docdir}" in doc package %files section

Nope. Packages that only contain documentation should not mark it %doc. If
someone wishes to skip installing the documentation he can simply skip
installing the package altogether, as there's nothing else there.

> - do not run tests by rake
> 
> - there is 1 failing test
> TestREADMErdoc#test_README.rdoc_Synopsis:
> Errno::ENOMEM: Cannot allocate memory - /usr/bin/ruby

The tests succeeds in mock (see above "mock:" link). This is probably specific
to your configuration -- either some rlimits, cgroups or lack of memory.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]