[Bug 1097584] Review Request: shiny - Shader and material management library for OGRE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1097584



--- Comment #5 from Martin Gieseking <martin.gieseking@xxxxxx> ---
I agree with Richard. If upstream doesn't want to offer shlib support, it's
also possible to manage it locally, but that's not necessarily required IMHO.

Just a short note:
Your patch looks good so far. In order to set the soversion, you have to add
something like the following to CMakeLists.txt. Just put it somewhere after
set(SHINY_LIBRARY ${SHINY_LIBRARY} PARENT_SCOPE):

set_target_properties(
  shiny
  PROPERTIES
    VERSION 0.0.0
    SOVERSION 0
)

As a result, you get the three files libshiny.so.0.0.0, libshiny.so.0, and
libshiny.so where the last two are symlinks. libshiny.so is a development file
and should go to the devel package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]