[Bug 1097426] Review Request: dpdk - dataplane development toolkit for optimized network appliances

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1097426



--- Comment #1 from Michael Schwendt <bugs.michael@xxxxxxx> ---
Just some spec file oddities:


> Version: 1.7.0 
> Release: 0.1.gitb20539d68 

https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages


> Summary: Intel(r) Data Plane Development Kit core

> %description
> Intel(r) DPDK core includes kernel modules, core libraries and tools.

https://fedoraproject.org/wiki/Packaging:Guidelines#Trademarks_in_Summary_or_Description


> Group: System Environment/Libraries

There are no system libraries included yet. See further below about the %files
section.


> ExclusiveArch: i686, x86_64

https://fedoraproject.org/wiki/Packaging:Guidelines#Architecture_Build_Failures



> %define target %{_arch}-default-linuxapp-gcc
> %define machine default

https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define

> %package devel

https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package


> %install
> rm -rf %{buildroot}

https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag


> %post
> /sbin/ldconfig
> /sbin/depmod

> %postun
> /sbin/ldconfig
> /sbin/depmod

> %files
> %{_libdir}/%{name}-%{version}

That directory is not in runtime linker's search path list, so running ldconfig
is superfluous.


> %doc %{docdir}

Files below %_docdir are implicitly marked as %doc. See "rpm -E
%__docdir_path".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]