https://bugzilla.redhat.com/show_bug.cgi?id=1058941 Björn Persson <bjorn@xxxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(bjorn@xn--rombobj | |rn-67a.se) | --- Comment #6 from Björn Persson <bjorn@xxxxxxxxxxxxxxxxxxxx> --- (In reply to Pavel Zhukov from comment #5) > Do we really have to package gps plugins? GPS is not packaged yet and review > is died for a long time. I suppose we don't have to package them. Do we have to exclude them? It's one little file, it does no harm when GPS isn't installed, and it's packaged with the documentation, not with the library itself. I still hope we'll get GPS packaged some day, and when that happens this package will be ready for it. > I can see testgtk description in the Makefile. Should/can we test build in > %check? Have not tested it tbh. TestGTK and Testcairo were already built together with the library. I see now that I can easily avoid building them in the build phase, and then build them in the check phase instead. That way I don't need to delete the binaries from the documentation. These demo programs are no replacement for a testsuite, but it doesn't hurt to build them to verify that it is at least possible to link programs to the library. https://www.rombobjörn.se/packages/GtkAda3-3.4.2-3/GtkAda3.spec https://www.rombobjörn.se/packages/GtkAda3-3.4.2-3/GtkAda3-3.4.2-3.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review